Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close-done-on-defer #4241

Merged
merged 5 commits into from
Jul 1, 2022
Merged

close-done-on-defer #4241

merged 5 commits into from
Jul 1, 2022

Conversation

sasurobert
Copy link
Contributor

new go mod

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2022

Codecov Report

Merging #4241 (b9367a4) into master (9b05242) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head b9367a4 differs from pull request most recent head e582a1b. Consider uploading reports for the commit e582a1b to get more accurate results

@@           Coverage Diff           @@
##           master    #4241   +/-   ##
=======================================
  Coverage   70.91%   70.91%           
=======================================
  Files         618      618           
  Lines       82457    82457           
=======================================
+ Hits        58472    58473    +1     
+ Misses      19758    19757    -1     
  Partials     4227     4227           
Impacted Files Coverage Δ
p2p/libp2p/netMessenger.go 75.66% <0.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b05242...e582a1b. Read the comment docs.

Copy link
Collaborator

@valentin-lup valentin-lup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated on 30.06.2022

Copy link
Contributor

@gabi-vuls gabi-vuls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System test passed. Errors are safe.

@@ Log scanner @@

close-done-on-panic

================================================================================

  • Known Warnings 7
  • New Warnings 1
  • Known Errors 0
  • New Errors 2
  • Panics 0
    ================================================================================

@iulianpascalau iulianpascalau merged commit 5ba9c12 into master Jul 1, 2022
@iulianpascalau iulianpascalau deleted the close-done-on-panic branch July 1, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants