Request node settings #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
miiu96
commented
Jun 7, 2023
miiu96
commented
- Implemented a mechanism that will request the node settings then the indexer binary will start.
process/dataindexer/dataIndexer.go
Outdated
| return nil | ||
| } | ||
|
|
||
| // CurrentSettings will set the provided settings |
cmd/elasticindexer/main.go
Outdated
| for { | ||
| err := host.Send([]byte{}, outport.TopicSettings) | ||
| if err != nil { | ||
| time.Sleep(time.Duration(retryDurationInSec) * time.Second) |
There was a problem hiding this comment.
please refactor this to allow the normal closing of the node if the settings were not received in time.
cmd/elasticindexer/main.go
Outdated
| for { | ||
| select { | ||
| case <-timer.C: | ||
| err := host.Send([]byte{}, outport.TopicSettings) |
There was a problem hiding this comment.
make([]byte, 0) instead of literal
bogdan-rosianu
approved these changes
Jun 9, 2023
iulianpascalau
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.