Remove data dispatcher #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdan-rosianu
previously approved these changes
Jun 6, 2023
| @@ -54,13 +54,6 @@ func NewIndexer(args ArgsIndexerFactory) (dataindexer.Indexer, error) { | |||
| return nil, err | |||
| } | |||
|
|
|||
| dispatcher, err := dataindexer.NewDataDispatcher(args.IndexerCacheSize) | |||
There was a problem hiding this comment.
can we also remove the args.IndexerCacheSize ?
process/dataindexer/dataIndexer.go
Outdated
| headerHash := outportBlock.BlockData.HeaderHash | ||
| shardID := header.GetShardID() | ||
| headerNonce := header.GetNonce() | ||
| defer func(startTime time.Time, headerHash []byte, headerNonce uint64, shardID uint32) { |
There was a problem hiding this comment.
we can remove all parameters from this list in order to simplify the call. We need the startTime := time.Now variable.
bogdan-rosianu
approved these changes
Jun 7, 2023
iulianpascalau
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dataDispatcher