Collections index #153
Merged
Collections index #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragos-rebegea
previously approved these changes
Jun 27, 2022
bogdan-rosianu
previously approved these changes
Jun 28, 2022
| @@ -189,7 +189,7 @@ func prepareSerializedAccountBalanceHistory( | |||
| } | |||
|
|
|||
| id += fmt.Sprintf("-%d", account.Timestamp) | |||
| meta := []byte(fmt.Sprintf(`{ "index" : { "_index":"%s", "_id" : "%s" } }%s`, index, id, "\n")) | |||
| meta := []byte(fmt.Sprintf(`{ "index" : { "_index":"%s", "_id" : "%s" } }%s`, index, converters.JsonEscape(id), "\n")) | |||
There was a problem hiding this comment.
since you prepare the ID, sanitizing is not necessary. but it can remain like this in order to avoid programming errors that would generate non readable characters
There was a problem hiding this comment.
Exactly this is an extra protection
dragos-rebegea
approved these changes
Jun 28, 2022
bogdan-rosianu
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESDTWipelog in case of an NFT/SFTcollectionsthat will keep information about a collectionconverters.JsonEscapeeverywhere