Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended fee info structure #345

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Extended fee info structure #345

merged 3 commits into from
Jan 16, 2025

Conversation

miiu96
Copy link
Contributor

@miiu96 miiu96 commented Jan 15, 2025

  • Extended fee info structure with an extra field

@miiu96 miiu96 mentioned this pull request Jan 15, 2025
Merged
ssd04
ssd04 reviewed Jan 16, 2025
View reviewed changes
data/outport/feeInfo.go
}

// SetHadRefund sets hadRefund field with true
func (f *FeeInfo) SetHadRefund() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we usually have setters with value; is it better to pass value? there might be the need to set it to false

@miiu96 miiu96 merged commit 32dcc2d into relayedv3 Jan 16, 2025
1 check passed
@miiu96 miiu96 deleted the relayed-v3-extend-fee-info branch January 16, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssd04 ssd04 ssd04 approved these changes

@sstanculeanu sstanculeanu sstanculeanu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miiu96 @ssd04 @sstanculeanu