Outport state changes. #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miiu96
reviewed
Sep 17, 2024
data/stateChange/stateChange.proto
Outdated
| bool OwnerAddress = 8 [(gogoproto.jsontag) = "ownerAddressChanged"]; | ||
| bool UserName = 9 [(gogoproto.jsontag) = "userNameChanged"]; | ||
| bool CodeMetadata = 10 [(gogoproto.jsontag) = "codeMetadataChanged"]; | ||
| } |
There was a problem hiding this comment.
add empty line at the end of the file
data/outport/outportBlock.proto
Outdated
| repeated uint64 SignersIndexes = 8 [(gogoproto.jsontag) = "signersIndexes,omitempty"]; | ||
| uint64 HighestFinalBlockNonce = 9 [(gogoproto.jsontag) = "highestFinalBlockNonce"]; | ||
| bytes HighestFinalBlockHash = 10 [(gogoproto.jsontag) = "highestFinalBlockHash,omitempty"]; | ||
| map <string, StateChanges> StateChanges = 6 [(gogoproto.jsontag) = "stateChanges,omitempty"]; |
There was a problem hiding this comment.
you should add your new field at the end of the structure to keep the backwards compatibility
miiu96
previously approved these changes
Sep 18, 2024
AdoAdoAdo
reviewed
Sep 18, 2024
data/stateChange/stateChange.proto
Outdated
|
|
||
| message StateChange { | ||
| string Type = 1 [(gogoproto.jsontag) = "type"]; | ||
| int32 Index = 2 [(gogoproto.jsontag) = "-"]; |
There was a problem hiding this comment.
can you also add some jsontags for the fields?
miiu96
previously approved these changes
Sep 18, 2024
AdoAdoAdo
reviewed
Sep 18, 2024
data/stateChange/stateChange.proto
Outdated
|
|
||
| message DataTrieChange { | ||
| string Type = 1 [(gogoproto.jsontag) = "type"]; | ||
| bytes Key = 2 [(gogoproto.jsontag) = "type"]; |
There was a problem hiding this comment.
update also the tags here
AdoAdoAdo
approved these changes
Sep 18, 2024
miiu96
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.