Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapted base chain #80

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Adapted base chain #80

wants to merge 4 commits into from

Conversation

iulianpascalau
Copy link
Contributor

  • adapted base chain

ccorcoveanu
ccorcoveanu reviewed Nov 29, 2024
View reviewed changes
contracts/ERC20Safe.sol Outdated
uint256[10] private __gap;
uint32 private __gap32;
uint64 private __gap64;
uint128 private __gap128;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can make the uint64 an array with capacity of three (not a strong opinion)

Copy link
Contributor Author

@iulianpascalau iulianpascalau Nov 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's try this 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccorcoveanu ccorcoveanu ccorcoveanu left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iulianpascalau @ccorcoveanu