Feat v3.5 #52
Merged
Feat v3.5 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nagement CII-56: Pending transactions management
CII-53: Deposit Endpoint
CII-54: Execute endpoint
CII-55: Finish execute gracefully
CII-58: Refund workflow
evelinemolnar
previously approved these changes
Aug 27, 2024
dragos-rebegea
commented
Aug 28, 2024
ccorcoveanu
requested changes
Aug 29, 2024
contracts/BridgeProxy.sol
Outdated
|
|
||
| require(txn.amount != 0, "BridgeProxy: No amount bridged"); | ||
|
|
||
| if (txn.callData.length > 0) { |
There was a problem hiding this comment.
would it be cleaner to do?:
if (txn.callData.length == 0) {
_finishExecuteGracefully(txId, true);
return;
}
There was a problem hiding this comment.
@cosmatudor I guess this still applies, wouldn't it read better with an early exit?
ccorcoveanu
reviewed
Aug 29, 2024
ccorcoveanu
reviewed
Aug 29, 2024
ccorcoveanu
reviewed
Aug 29, 2024
CostinCarabas
previously approved these changes
Sep 12, 2024
ccorcoveanu
reviewed
Sep 16, 2024
ccorcoveanu
requested changes
Sep 16, 2024
ccorcoveanu
reviewed
Sep 16, 2024
| function execute(uint256 txId) external whenNotPaused { | ||
| require(txId < currentTxId, "BridgeExecutor: Invalid transaction ID"); | ||
| MvxTransaction memory txn = pendingTransactions[txId]; | ||
|
|
There was a problem hiding this comment.
We should also have a check that txn still exists (it was not deleted). In case of reentrancy, when reaching back into this code, it will go on the else case, _refundAndDeleteTxn(txId);. Indeed it will try to transfer 0 back and the call will fail, but let's actually catch this behaviour and revert
ccorcoveanu
approved these changes
Sep 18, 2024
CostinCarabas
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.