Upgradable contracts implementation #43
Conversation
contracts/ERC20Safe.sol
Outdated
| @@ -52,6 +53,18 @@ contract ERC20Safe is BridgeRole, Pausable { | |||
| event ERC20Deposit(uint112 depositNonce, uint112 batchId); | |||
| event ERC20SCDeposit(uint112 indexed batchId, uint112 depositNonce, string callData); | |||
There was a problem hiding this comment.
if you compile the sol contracts, this event will have the CallData field defined as string not []byte. @dragos-rebegea did a recent change in which we changed this field from string to []byte to avoid double hex encoding. How do we fix this?
There was a problem hiding this comment.
merged Dragos's changes, should be good now
@iulianpascalau I will push them now, but I don't really like this approach, even small PRs become very bloated with generated files, maybe we can think of an alternative? |
Yes, we can think of a better system for generating binaries. Maybe a docker image that will do all the time this thing for us and publish the binaries as artifacts at release time? 🤔 |
No description provided.