link refund tx to initial tx #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragos-rebegea
commented
Oct 18, 2024
bridged-tokens-wrapper/src/lib.rs
Outdated
| @@ -6,6 +6,7 @@ mod events; | |||
| use core::ops::Deref; | |||
|
|
|||
| pub use dfp_big_uint::DFPBigUint; | |||
| use esdt_safe_proxy::RefundInfo; | |||
There was a problem hiding this comment.
you dont have to import the struct explicitly
Coverage SummaryTotals
FilesExpand
|
|
Contract comparison - from 10502db to ef221a3
|
iulianpascalau
requested review from
CostinCarabas,
iulianpascalau and
evelinemolnar
CostinCarabas
approved these changes
Oct 18, 2024
evelinemolnar
approved these changes
Oct 18, 2024
Comment on lines
+357
to
+364
| self.create_refund_transaction_event( | ||
| batch_id, | ||
| tx_nonce, | ||
| payment_token, | ||
| actual_bridged_amount, | ||
| required_fee, | ||
| refund_info.initial_batch_id, | ||
| refund_info.initial_nonce, |
There was a problem hiding this comment.
I think we also need to include the refund address and tx.to in the create_refund_transaction_event because if we do not receive the create_transaction_event before, we don't have all the details to index the "refunded" swap in ES
| @@ -34,7 +34,7 @@ pub trait BridgeProxyContract: | |||
|
|
|||
| #[payable("*")] | |||
| #[endpoint] | |||
| fn deposit(&self, eth_tx: EthTransaction<Self::Api>) { | |||
| fn deposit(&self, eth_tx: EthTransaction<Self::Api>, batch_id: u64) { | |||
There was a problem hiding this comment.
I would not put this mandatory argument here, which is useless in the case we want to do a normal swap from Mvx->Eth
Instead, why not create a depositWithLinkedBatchID function? And that should be called from the bridge proxy SC
This is the bridge proxy SC, not the esdt safe
iulianpascalau
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.