Skip to content

V3.1 audit fixes

V3.1 audit fixes #916

Triggered via pull request November 21, 2024 22:26
Status Success
Total duration 4m 45s
Artifacts 4

actions.yml

on: pull_request
Contracts  /  Wasm tests
4m 35s
Contracts / Wasm tests
Contracts  /  Test Coverage
3m 15s
Contracts / Test Coverage
Contracts  /  Rust tests
46s
Contracts / Rust tests
Contracts  /  Clippy linter check
16s
Contracts / Clippy linter check
Fit to window
Zoom out
Zoom in

Annotations

7 warnings
[clippy] common/token-module/src/lib.rs#L243: common/token-module/src/lib.rs#L243
warning: equality checks against false can be replaced by a negation --> common/token-module/src/lib.rs:243:13 | 243 | self.supply_mint_burn_initialized(token_id).get() == false, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.supply_mint_burn_initialized(token_id).get()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison = note: `#[warn(clippy::bool_comparison)]` on by default
[clippy] common/token-module/src/lib.rs#L243: common/token-module/src/lib.rs#L243
warning: equality checks against false can be replaced by a negation --> common/token-module/src/lib.rs:243:13 | 243 | self.supply_mint_burn_initialized(token_id).get() == false, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.supply_mint_burn_initialized(token_id).get()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison = note: `#[warn(clippy::bool_comparison)]` on by default
Contracts / Clippy linter check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, giraffate/clippy-action@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Contracts / Rust tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Contracts / Test Coverage
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/upload-artifact@v3, peter-evans/find-comment@v2, peter-evans/create-or-update-comment@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Contracts / Wasm tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/upload-artifact@v3, dawidd6/action-download-artifact@v2, peter-evans/find-comment@v2, peter-evans/create-or-update-comment@v2. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "coverage", "mxpy_report", "report", "report-markdown". Please update your workflow to use v4 of the artifact actions. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Artifacts

Produced during runtime
Name Size
coverage
5.99 KB
mxpy_report
13.9 KB
report
1.07 KB
report-markdown
1.18 KB