Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added execute transfer functionality #334

Merged
merged 7 commits into from
Sep 6, 2024
Merged

Conversation

iulianpascalau
Copy link
Contributor

No description provided.

@iulianpascalau iulianpascalau marked this pull request as ready for review September 6, 2024 09:41
Comment on lines 175 to 176
for _, sigInfo := range executor.signatures {
if sigInfo.MessageHash != executor.batch.MessageHash.String() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for _, sigInfo := range executor.signatures {
if sigInfo.MessageHash != executor.batch.MessageHash.String() {
expectedSignature := executor.batch.MessageHash.String()
for _, sigInfo := range executor.signatures {
if sigInfo.MessageHash != expectedSignature {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

whitelistedRelayers[relayerAddress] = sigInfo
}

result := make([][]byte, 0, len(whitelistedRelayers))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
result := make([][]byte, 0, len(whitelistedRelayers))
validSignatures := make([][]byte, 0, len(whitelistedRelayers))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed

@dragos-rebegea dragos-rebegea merged commit a8ceae9 into feat/migration-app Sep 6, 2024
4 checks passed
@dragos-rebegea dragos-rebegea deleted the execute branch September 6, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants