Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrated new go-ethereum version and the new mvx node version #325

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Integrated new go-ethereum version and the new mvx node version #325

merged 2 commits into from
Aug 21, 2024

Conversation

iulianpascalau
Copy link
Contributor

  • integrated new go-ethereum version and the new mvx node version
  • added a new gas station test server component

@iulianpascalau
- integrated new go-ethereum version and the new mvx node version
19c615e 
- added a new gas station test server component
sstanculeanu
sstanculeanu reviewed Aug 20, 2024
View reviewed changes
integrationTests/relayers/slowTests/framework/ethereumHandler.go Outdated
require.NoError(handler, err)

// set bridge on safe
auth, _ := bind.NewKeyedTransactorWithChainID(handler.OwnerKeys.EthSK, handler.ChainID)
tx, err := ethSafeContract.SetBridge(auth, handler.BridgeAddress)

gasprice, _ := handler.SimulatedChain.Client().SuggestGasPrice(context.Background())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

require.NoError(handler, err) before this line + replace _ with err here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will fix 👍

@iulianpascalau iulianpascalau merged commit 5d8693a into feat/v3 Aug 21, 2024
4 checks passed
@iulianpascalau iulianpascalau deleted the new-deps-version-2024.08.20 branch August 21, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragos-rebegea dragos-rebegea dragos-rebegea approved these changes

@sstanculeanu sstanculeanu sstanculeanu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iulianpascalau @sstanculeanu @dragos-rebegea