More tests with simulated environments #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h-go into simulate_eth # Conflicts: # clients/ethereum/wrappers/ethereumChainWrapper.go # clients/ethereum/wrappers/interface.go # clients/multiversx/interface.go # testsCommon/bridge/safeContractStub.go # testsCommon/interactors/proxyStub.go
…e-eth-go into more_tests # Conflicts: # clients/multiversx/interface.go # integrationTests/relayers/ethToMultiversXWithChainSimulator_test.go # integrationTests/relayers/testdata/contracts/mvx/bridged-tokens-wrapper.wasm # integrationTests/relayers/testdata/contracts/mvx/esdt-safe.wasm # integrationTests/relayers/testdata/contracts/mvx/multi-transfer-esdt.wasm # integrationTests/relayers/testdata/contracts/mvx/multisig.wasm # testsCommon/interactors/proxyStub.go
sstanculeanu
changed the title
integrationTests/relayers/ethToMultiversXWithChainSimulator_test.go
Outdated
Show resolved
Hide resolved
integrationTests/relayers/ethToMultiversXWithChainSimulator_test.go
Outdated
Show resolved
Hide resolved
integrationTests/relayers/ethToMultiversXWithChainSimulator_test.go
Outdated
Show resolved
Hide resolved
integrationTests/relayers/ethToMultiversXWithChainSimulator_test.go
Outdated
Show resolved
Hide resolved
integrationTests/relayers/ethToMultiversXWithChainSimulator_test.go
Outdated
Show resolved
Hide resolved
| // start a mocked log observer that is looking for a specific relayer error | ||
| chanCnt := 0 | ||
| mockLogObserver := mock.NewMockLogObserver(expectedStringInLogs) | ||
| err := logger.AddLogObserver(mockLogObserver, &logger.PlainFormatter{}) |
There was a problem hiding this comment.
Interesting approach. However, care should be taken when using static methods & variables as used in the logger package.
Maybe add some comment warnings to not run tests in parallel from the current package?
Better, create a dedicated package for these slow tests?
There was a problem hiding this comment.
moved to relayers_test
There was a problem hiding this comment.
I was referring to a new directory
integrationTests/relayers/ethToMultiversXWithChainSimulator_test.go
Outdated
Show resolved
Hide resolved
| case <-interrupt: | ||
| require.Fail(t, "signal interrupted") | ||
| return | ||
| case <-time.After(time.Minute * 15): |
| case <-interrupt: | ||
| require.Fail(t, "signal interrupted") | ||
| return | ||
| case <-time.After(time.Minute * 15): |
| case <-interrupt: | ||
| require.Fail(t, "signal interrupted") | ||
| return | ||
| case <-time.After(time.Minute * 15): |
iulianpascalau
approved these changes
Jun 26, 2024
dragos-rebegea
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.