MVX-> ETH integration test swap with chain simulator #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sstanculeanu
commented
Mar 5, 2024
sstanculeanu
commented
- added swap back to eth
- proper wait for tx to be done
- updated contracts
sstanculeanu
changed the title
| } | ||
|
|
||
| // wait for tx to be done, in order to get the contract address | ||
| timeoutTimer := time.NewTimer(instance.roundDuration * 5) | ||
| timeoutTimer := time.NewTimer(instance.roundDuration * 20) |
There was a problem hiding this comment.
this timer is only a fallback protection as the proxyInstance.ProcessTransactionStatus should always give a result.
However, the approach is a little bit misleading because it will block the tes forever if one transaction is failed. I will try to come up with a better solution to this.
There was a problem hiding this comment.
updated as suggested
| } | ||
|
|
||
| if ethToMVXDone && mvxToETHDone { | ||
| log.Info("MVX<->ETH transfers done") |
| @@ -757,13 +820,13 @@ func issueAndWhitelistToken( | |||
|
|
|||
| log.Info("multi-transfer set max bridge amount for token tx executed", "hash", hash, "status", txResult.Status) | |||
|
|
|||
| return newUniversalToken | |||
| return newUniversalToken, newChainSpecificToken | |||
There was a problem hiding this comment.
a little bit misleading that we return 2 string parameters here. Not having a better solution, thus.
iulianpascalau
previously approved these changes
Mar 6, 2024
iulianpascalau
previously approved these changes
Mar 8, 2024
iulianpascalau
approved these changes
Mar 11, 2024
dragos-rebegea
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.