Fix backwards compatibility #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| var notImplemented = errors.New("method not implemented") | ||
|
|
||
| var CallDataMock = func() []byte { |
There was a problem hiding this comment.
missing mock comment
| @@ -480,16 +480,15 @@ func getStatusFromBuff(buff []byte) (byte, error) { | |||
|
|
|||
| func addBatchInfo(builder builders.VMQueryBuilder, batch *clients.TransferBatch) { | |||
| for _, dt := range batch.Deposits { | |||
| if dt.Data == nil { | |||
| continue | |||
There was a problem hiding this comment.
is this a dead code? Are there any chances to have a nil data here? Maybe log.Error as this is a programming error
There was a problem hiding this comment.
removed. it was actually dead code and anyway the builder would throw an error when executing the query ift data field would be nil
Minor refactor for the ConvertToDisplayableData function
iulianpascalau
approved these changes
Feb 26, 2024
sstanculeanu
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.