Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

websockets transactions events metrics #1429

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

cfaur09
Copy link
Contributor

@cfaur09 cfaur09 commented Jan 3, 2025

Reasoning

  • Need visibility into total WebSocket events at cluster level
  • Missing basic counters for core WebSocket operations. (transactionsCompleted, transactionsPendingResults, onBatchUpdated

Proposed Changes

  • Added three simple counters:
  • websocket_transactions_completed_total
  • websocket_transactions_pending_results_total
  • websocket_batch_updates_total

How to test

  • <localhost:4001>/metrics

Copy link

github-actions bot commented Jan 3, 2025

k6 load testing comparison.
Base Commit Hash: 8135bf8
Target Commit Hash: 471468b

Metric Base Target Diff
AvgMax9095AvgMax9095AvgMax9095
Accounts47.08224.6151.0752.6151.261250.9454.1455.49+8.86% 🔴+456.94% 🔴+6.01% 🔴+5.48% 🔴
Mex47.46502.8051.0552.5250.47674.0454.1555.42+6.33% 🔴+34.06% 🔴+6.08% 🔴+5.51% 🔴
Pool47.12281.4351.0952.5849.77196.1054.1255.39+5.63% 🔴-30.32% ✅+5.93% 🔴+5.35% 🔴
Nodes47.69845.3651.0552.5149.61140.8354.1055.37+4.02% 🔴-83.34% ✅+5.98% 🔴+5.45% 🔴
Transactions60.121281.0651.5453.4367.012298.8454.5456.34+11.46% 🔴+79.45% 🔴+5.83% 🔴+5.43% 🔴
Tokens46.85110.0851.0252.4850.17499.4854.1655.43+7.09% 🔴+353.74% 🔴+6.15% 🔴+5.61% 🔴
Blocks52.541021.6551.4353.5756.571236.3854.5356.42+7.68% 🔴+21.02% 🔴+6.04% 🔴+5.32% 🔴
Test Run Duration60003.7760003.60

Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile
All times are in milliseconds.

@dragos-rebegea dragos-rebegea merged commit 0937b65 into development Jan 8, 2025
5 checks passed
@dragos-rebegea dragos-rebegea deleted the API-365-websockets-transactions-metrics branch January 8, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants