Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-91: type + subType fixes #1390

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

bogdan-rosianu
Copy link
Contributor

Reasoning

  • there were some inconsistencies with endpoints that return new NFTs

Proposed Changes

  • added subType to missling places

How to test

  • <api>/accounts/<address>/tokens for an address that has a dynamic MetaESDT should have type set to MetaESDT and subType set to DynamicMetaESDT

@bogdan-rosianu bogdan-rosianu self-assigned this Nov 21, 2024
Copy link

github-actions bot commented Nov 21, 2024

k6 load testing comparison.
Base Commit Hash: 820bbf2
Target Commit Hash: a35c64a

Metric Base Target Diff
AvgMax9095AvgMax9095AvgMax9095
Blocks54.921336.1751.8353.8451.971503.4750.3952.61-5.37% ✅+12.52% 🔴-2.79% ✅-2.28% ✅
Transactions60.941859.2751.8954.0962.222193.0350.7252.55+2.10% 🔴+17.95% 🔴-2.26% ✅-2.84% ✅
Mex47.00430.8351.4352.6045.83275.4050.1351.56-2.48% ✅-36.08% ✅-2.52% ✅-1.98% ✅
Tokens47.64802.2951.4752.7146.20606.8450.1351.58-3.02% ✅-24.36% ✅-2.61% ✅-2.15% ✅
Nodes47.47497.9051.5052.7245.87336.4150.1351.60-3.36% ✅-32.43% ✅-2.65% ✅-2.13% ✅
Pool47.75774.8151.4752.7846.05459.7150.1251.58-3.57% ✅-40.67% ✅-2.62% ✅-2.28% ✅
Accounts47.63788.4651.4852.7946.55866.3350.0751.57-2.26% ✅+9.88% 🔴-2.74% ✅-2.30% ✅
Test Run Duration60002.9960002.06

Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile
All times are in milliseconds.

@cfaur09 cfaur09 merged commit a4cbeb0 into development Nov 21, 2024
5 checks passed
@cfaur09 cfaur09 deleted the API-91-api-type-sub-type-fixes branch November 21, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants