Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add round filter for transactions / transfers #1365

Conversation

cfaur09
Copy link
Contributor

@cfaur09 cfaur09 commented Oct 29, 2024

Proposed Changes

  • added round filter for the following endpoints
  • transfers -> transactions -> accounts/:address/transactions -> accounts/:address/transfers -> accounts/:address/transactions/count -> accounts/:address/transfers/count -> collections/:identifier/transfers -> collections/:identifier/transfers/count -> collections/:identifier/transactions -> collections/:identifier/transactions/count -> tokens/:identifier/transactions -> tokens/:identifier/transactions/count -> tokens/:identifier/transfers -> tokens/:identifier/transfers/count

How to test

  • <api>/transactions?round=270791
  • <api>/transactions/count?round=270791
  • <api>/transfers?round=270791
  • <api>/transfers/count?round=270791
  • <api>/accounts/erd1essu6c8rv6n35s6whfklxj907e22msu786vzd9m65802qf2y9ukq8uqmtw/transactions?round=270791
  • <api>/accounts/erd1essu6c8rv6n35s6whfklxj907e22msu786vzd9m65802qf2y9ukq8uqmtw/transactions/count?round=270791
  • <api>/accounts/erd1essu6c8rv6n35s6whfklxj907e22msu786vzd9m65802qf2y9ukq8uqmtw/transfers?round=270791
  • <api>/accounts/erd1essu6c8rv6n35s6whfklxj907e22msu786vzd9m65802qf2y9ukq8uqmtw/transfers/count?round=270791
  • <api>/tokens/ROSETTA-449e95/transactions?round=154696
  • <api>/tokens/ROSETTA-449e95/transactions/count?round=154696
  • <api>/tokens/ROSETTA-449e95/transfers?round=154696
  • <api>/tokens/ROSETTA-449e95/transfers/count?round=154696
  • <api>/collections/NFTOOTH-bad29b/transactions?round=54697
  • <api>/collections/NFTOOTH-bad29b/transactions/count?round=54697

@cfaur09 cfaur09 added the feature New feature or request label Oct 29, 2024
@cfaur09 cfaur09 self-assigned this Oct 29, 2024
Copy link

k6 load testing comparison.
Base Commit Hash: eb122d9
Target Commit Hash: caae23c

Metric Base Target Diff
AvgMax9095AvgMax9095AvgMax9095
Nodes53.80826.6159.9665.7154.52140.6064.7271.86+1.34% 🔴-82.99% ✅+7.94% 🔴+9.36% 🔴
Transactions79.522901.2962.8873.6487.573643.1470.1979.60+10.13% 🔴+25.57% 🔴+11.62% 🔴+8.10% 🔴
Accounts52.66232.8359.8864.8655.52818.1064.7572.65+5.43% 🔴+251.37% 🔴+8.14% 🔴+12.01% 🔴
Tokens53.55711.1059.8665.5554.95366.8264.8071.98+2.62% 🔴-48.42% ✅+8.25% 🔴+9.80% 🔴
Blocks63.102301.7361.4471.0967.842303.1066.6176.95+7.51% 🔴+0.06% 🔴+8.42% 🔴+8.25% 🔴
Mex53.63727.9059.9465.5255.58801.2764.8272.47+3.64% 🔴+10.08% 🔴+8.13% 🔴+10.61% 🔴
Pool53.13334.5459.7765.6355.09476.8864.7872.23+3.68% 🔴+42.55% 🔴+8.38% 🔴+10.05% 🔴
Test Run Duration60002.0560002.01

Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile
All times are in milliseconds.

@bogdan-rosianu bogdan-rosianu self-requested a review October 29, 2024 14:37
@dragos-rebegea dragos-rebegea merged commit affe405 into development Oct 29, 2024
5 checks passed
@dragos-rebegea dragos-rebegea deleted the SERVICES-2688-add-support-for-transaction-filter-by-round branch October 29, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants