Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring e2e controller tests #1208

Merged
merged 30 commits into from
Feb 29, 2024

Conversation

cfaur09
Copy link
Contributor

@cfaur09 cfaur09 commented Feb 23, 2024

Reasoning

  • E2E tests now are implementing using real date from the network, and in most cases we are facing a lot of Rate Limits for executing all e2e tests

Proposed Changes

  • Create more robust tests that include services mocks for each controller

How to test

  • npm run test:e2e

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.80%. Comparing base (3efb2dc) to head (c1d290a).

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1208      +/-   ##
===============================================
+ Coverage        39.11%   45.80%   +6.68%     
===============================================
  Files                9      590     +581     
  Lines              317    15555   +15238     
  Branches            19     1641    +1622     
===============================================
+ Hits               124     7125    +7001     
- Misses             174     6849    +6675     
- Partials            19     1581    +1562     
Flag Coverage Δ
unittests 45.80% <ø> (+6.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cfaur09 cfaur09 marked this pull request as draft February 23, 2024 10:07
@cfaur09 cfaur09 added test Create or update unit / integration tests refactoring The same functionality is maintained, but in an improved way labels Feb 26, 2024
@bogdan-rosianu bogdan-rosianu self-requested a review February 27, 2024 08:33
@cfaur09 cfaur09 marked this pull request as ready for review February 27, 2024 08:33
@tanghel tanghel merged commit f4e7b4d into development Feb 29, 2024
5 checks passed
@tanghel tanghel deleted the SERVICES-2163-refactoring-e-2-e-tests branch February 29, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring The same functionality is maintained, but in an improved way test Create or update unit / integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants