Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

superman: Initial fixes #572

Merged
merged 3 commits into from
Nov 5, 2024
Merged

superman: Initial fixes #572

merged 3 commits into from
Nov 5, 2024

Conversation

ds1-e
Copy link
Contributor

@ds1-e ds1-e commented Nov 2, 2024 •
edited
Loading

  • Use localPlayer instead of root in triggerServerEvent
  • Remove unnecessary variable
  • Add missing player in getPedControlState
  • Disable cache for client.lua

@jlillis
Copy link
Contributor

jlillis commented Nov 5, 2024

Could you fix the linter errors as well?

Checking [gameplay]/superman/client.lua           5 warnings

    [gameplay]/superman/client.lua:173:8: variable player was previously defined as an argument on line 171
    [gameplay]/superman/client.lua:180:8: variable player was previously defined as an argument on line 178
    [gameplay]/superman/client.lua:625:22: used variable _x with unused hint
    [gameplay]/superman/client.lua:625:26: used variable _y with unused hint
    [gameplay]/superman/client.lua:625:30: used variable _z with unused hint

@jlillis jlillis added this to the Next Release (1.6.1) milestone Nov 5, 2024
@jlillis
Copy link
Contributor

jlillis commented Nov 5, 2024

Thanks!

@jlillis jlillis merged commit 2b3bc10 into multitheftauto:master Nov 5, 2024
1 check passed
MittellBuurman pushed a commit to MittellBuurman/mtasa-resources that referenced this pull request Nov 11, 2024
@ds1-e @MittellBuurman
superman: Initial fixes (multitheftauto#572)
3502c19 
* Initial fixes for superman

* Update meta.xml

* Fix lint warnings.
@ds1-e ds1-e deleted the superman-init-fix branch November 14, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement resource:superman
Projects
None yet
Milestone
Next Release (1.6.1)
Development

Successfully merging this pull request may close these issues.
2 participants
@ds1-e @jlillis