support for setsockopt(SOL_IP) #220

dcaratti · 2021-07-29T20:48:13Z

add kernel support for setsockopt(SOL_IP), since mptcp_supported_sockopt() returns true but then nobody handles SOL_IP in mptcp_setsockopt().

implement support for IP_TOS and assess the correct behavior using packetdrill

The text was updated successfully, but these errors were encountered:

dcaratti · 2021-07-29T20:49:19Z

@spoorva is working on this

matttbe · 2021-08-04T09:59:22Z

@spoorva : please assign yourself on this ticket once you joined mptcp-upstream-devs team.

This sockopt was not validated before. Currently not supported by MPTCP but it's implementation is in progress. See issue multipath-tcp/mptcp_net-next#220 Signed-off-by: Poorva Sonparote <[email protected]>

spoorva · 2021-10-20T17:08:01Z

Adding the packetdrill test for the above here -

--tolerance_usecs=100000
`../common/defaults.sh`
 
+0    `../common/client.sh`
 
+0.0    socket(..., SOCK_STREAM, IPPROTO_MPTCP) = 7                          
+0.0    setsockopt(7, SOL_IP, IP_TOS, [4], 4) = 0                        
//+0.200  getsockopt(7, SOL_IP, IP_TOS, [4], [4]) = 0  
 
+0.0  fcntl(7, F_GETFL) = 0x2 (flags O_RDWR)
+0.0  fcntl(7, F_SETFL, O_RDWR|O_NONBLOCK) = 0
 
+0.0  connect(7, ..., ...) = -1  EINPROGRESS (Operation now in progress)
 
 
 
+0.0    > [tos 0x04]    addr[caddr0] > addr[saddr0]  S   0:0(0)                        <mss 1460, sackOK, TS val 4074410674 ecr 0,          nop, wscale 8, mpcapable v1 flags[flag_h] nokey>
 
+0.0    <                                            S.  0:0(0)      ack 1  win 65535  <mss 1460, sackOK, TS val 4074410674 ecr 4074410674, nop, wscale 8, mpcapable v1 flags[flag_h] key[skey=2]>
 
+0.0    > [tos 0x04]                                 .  1:1(0)      ack 1             <nop, nop,         TS val 4074410674 ecr 4074410674,                mpcapable v1 flags[flag_h] key[ckey, skey]>
 
//+0.2  getsockopt(7, SOL_IP, IP_TOS, [4], [4]) = 0
+0.0  fcntl(7, F_SETFL, O_RDWR) = 0   // set back to blocking
 
 +0.2    setsockopt(7, SOL_IP, IP_TOS, [4], 4) = 0
 
+1.0  write(7, ..., 2) = 2
+0.0    >  [tos 0x04]                             P.  1:3(2)      ack 1             <nop, nop, TS val 4074418292 ecr 4074410674,                        mpcapable v1 flags[flag_h] key[ckey, skey] mpcdatalen 2, nop, nop>
+0.0    <                                          .  1:1(0)      ack 3  win 256    <nop, nop, TS val 4074418293 ecr 4074418292,       add_address addr[saddr1] hmac=auto>
 
 +0.2    setsockopt(7, SOL_IP, IP_TOS, [4], 4) = 0
 
 
+0.0    >  [tos 0x04]               > addr[saddr1]  S   0:0(0)                        <mss 1460, sackOK, TS val 448955294 ecr 0,         nop, wscale 8, mp_join_syn     address_id=0 token=sha256_32(skey)>
+0.0    >  [tos 0x04]               > addr[saddr0]   .  3:3(0)      ack 1             <nop, nop,         TS val 448955294 ecr 448955294, add_address addr[saddr1] addr_echo>
+0.0    <                                           S.  0:0(0)      ack 1  win 65535  <mss 1460, sackOK, TS val 448955294 ecr 448955294, nop, wscale 8, mp_join_syn_ack address_id=1 sender_hmac=auto>
+0.0    >  [tos 0x04]                                .  1:1(0)      ack 1             <nop, nop,         TS val 448955294 ecr 448955294,                mp_join_ack                  sender_hmac=auto>
 
//+0.0    setsockopt(7, SOL_IP, IP_TOS, [4], 4) = 0
 
 
+0.1  close(7) = 0
 
+0.0    >   addr[caddr0] > addr[saddr0]   .  3:3(0)      ack 1    win 256         <nop, nop, TS val 4074418292 ecr 4074418293,dss dack4=1 dsn8=3 ssn=0 dll=1  nocs fin, nop, nop>
 
+0.0    >                                 .  1:1(0)      ack 1  win 256         <nop, nop, TS val 4074418292 ecr 4074418293,dss dack4=1 dsn8=3 ssn=0 dll=1  nocs fin, nop, nop>

Hello! I have been working on adding support for IP_TOS for setsockopt(). I am attaching the packetdrill test and the patch but it still won't set the TOS value for the subflows that are created after the setsockopt() call. multipath-tcp/mptcp_net-next#220 (comment) Thanks, Poorva This patch adds support for IP_TOS for setsockopt(.. ,SOL_IP, ..) multipath-tcp/mptcp_net-next#220 Currently, any new subflows that are created after the setsockopt() call are not being updated with the set IP_TOS value. Signed-off-by: Poorva Sonparote <[email protected]>

matttbe · 2021-10-21T06:46:02Z

FYI, the CI found some issues with the last patch you sent:

spoorva · 2021-10-25T16:00:35Z

FYI, the CI found some issues with the last patch you sent:
* https://cirrus-ci.com/task/5316374168862720

* https://cirrus-ci.com/task/6442274075705344

Looking into it.

This patch adds support for IP_TOS for setsockopt(.. ,SOL_IP, ..) multipath-tcp/mptcp_net-next#220 Closes: multipath-tcp/mptcp_net-next#220 Signed-off-by: Poorva Sonparote <[email protected]>

SOL_IP provides a way to configure network layer attributes in a socket. This patch adds support for IP_TOS for setsockopt(.. ,SOL_IP, ..) multipath-tcp/mptcp_net-next#220 Support for SOL_IP is added in mptcp_setsockopt() and IP_TOS is handled in a private function. The idea here is to take in the value passed for IP_TOS and set it to the current subflow, open subflows as well new subflows that might be created after the initial call to setsockopt(). This sync is done using sync_socket_options(.., ssk) and setting the value of tos using __ip_sock_set_tos(ssk,..). To set the value for all subflows associated, __ip_sock_set_tos(ssk,..) is exposed in ip.h The patch has been tested using the packetdrill script here - multipath-tcp/mptcp_net-next#220 (comment) It has not been selftested because there's no support for IP_TOS in getsockopt() yet. Closes: multipath-tcp/mptcp_net-next#220 Signed-off-by: Poorva Sonparote <[email protected]>

SOL_IP provides a way to configure network layer attributes in a socket. This patch adds support for IP_TOS for setsockopt(.. ,SOL_IP, ..) multipath-tcp/mptcp_net-next#220 Support for SOL_IP is added in mptcp_setsockopt() and IP_TOS is handled in a private function. The idea here is to take in the value passed for IP_TOS and set it to the current subflow, open subflows as well new subflows that might be created after the initial call to setsockopt(). This sync is done using sync_socket_options(.., ssk) and setting the value of tos using __ip_sock_set_tos(ssk,..). The patch has been tested using the packetdrill script here - multipath-tcp/mptcp_net-next#220 (comment) It has not been selftested because there's no support for IP_TOS in getsockopt() yet. Closes: multipath-tcp/mptcp_net-next#220 Signed-off-by: Poorva Sonparote <[email protected]>

SOL_IP provides a way to configure network layer attributes in a socket. This patch adds support for IP_TOS for setsockopt(.. ,SOL_IP, ..) multipath-tcp/mptcp_net-next#220 Support for SOL_IP is added in mptcp_setsockopt() and IP_TOS is handled in a private function. The idea here is to take in the value passed for IP_TOS and set it to the current subflow, open subflows as well new subflows that might be created after the initial call to setsockopt(). This sync is done using sync_socket_options(.., ssk) and setting the value of tos using __ip_sock_set_tos(ssk,..). The patch has been tested using the packetdrill script here - multipath-tcp/mptcp_net-next#220 (comment) Reported-by: kernel test robot <[email protected]> Closes: multipath-tcp/mptcp_net-next#220 Signed-off-by: Poorva Sonparote <[email protected]>

SOL_IP provides a way to configure network layer attributes in a socket. This patch adds support for IP_TOS for setsockopt(.. ,SOL_IP, ..) #220 Support for SOL_IP is added in mptcp_setsockopt() and IP_TOS is handled in a private function. The idea here is to take in the value passed for IP_TOS and set it to the current subflow, open subflows as well new subflows that might be created after the initial call to setsockopt(). This sync is done using sync_socket_options(.., ssk) and setting the value of tos using __ip_sock_set_tos(ssk,..). The patch has been tested using the packetdrill script here - #220 (comment) Reported-by: kernel test robot <[email protected]> Closes: #220 Signed-off-by: Poorva Sonparote <[email protected]>

matttbe · 2021-10-28T11:31:58Z

@spoorva before closing this ticket, may you create a PR to add your new test script in our packetdrill repo please?

commit ffcacff upstream. SOL_IP provides a way to configure network layer attributes in a socket. This patch adds support for IP_TOS for setsockopt(.. ,SOL_IP, ..) Support for SOL_IP is added in mptcp_setsockopt() and IP_TOS is handled in a private function. The idea here is to take in the value passed for IP_TOS and set it to the current subflow, open subflows as well new subflows that might be created after the initial call to setsockopt(). This sync is done using sync_socket_options(.., ssk) and setting the value of tos using __ip_sock_set_tos(ssk,..). The patch has been tested using the packetdrill script here - multipath-tcp/mptcp_net-next#220 (comment) Closes: multipath-tcp/mptcp_net-next#220 Signed-off-by: Poorva Sonparote <[email protected]> Signed-off-by: Mat Martineau <[email protected]> Signed-off-by: David S. Miller <[email protected]> (cherry picked from commit ffcacff)

spoorva pushed a commit to spoorva/mptcp_net-next that referenced this issue Aug 3, 2021

multipath-tcp#220 : Support for setsockopt(SOL_IP)

d4ee03b

matttbe added the enhancement label Aug 4, 2021

matttbe closed this as completed in dd03695 Oct 28, 2021

matttbe reopened this Oct 28, 2021

matttbe closed this as completed in afdb45c Oct 28, 2021

spoorva mentioned this issue Oct 28, 2021

Packetdrill: Add coverage for setsockopt(SOL_IP, IP_TOS) #238

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support for setsockopt(SOL_IP) #220

support for setsockopt(SOL_IP) #220

dcaratti commented Jul 29, 2021

dcaratti commented Jul 29, 2021

matttbe commented Aug 4, 2021

spoorva commented Oct 20, 2021

matttbe commented Oct 21, 2021

spoorva commented Oct 25, 2021

matttbe commented Oct 28, 2021

support for setsockopt(SOL_IP) #220

support for setsockopt(SOL_IP) #220

Comments

dcaratti commented Jul 29, 2021

dcaratti commented Jul 29, 2021

matttbe commented Aug 4, 2021

spoorva commented Oct 20, 2021

matttbe commented Oct 21, 2021

spoorva commented Oct 25, 2021

matttbe commented Oct 28, 2021