mptcp: fullmesh: missing comma in addr list

/proc/net/mptcp_fullmesh lists all available addresses with some attributes separated with commas. One is missing: $ cat /proc/net/mptcp_fullmesh Index, Address-ID, Backup, IP-address, if-idx IPv4, next v4-index: 2 1, 2, 0, 1.2.3.4 2 For the last line, we should hag: 1, 2, 0, 1.2.3.4, 2 A detail but interesting if someone needs to parse the output. Fixes: 7aff306 ("mptcp_fullmesh: Better debugging") Signed-off-by: Matthieu Baerts <[email protected]> Signed-off-by: Christoph Paasch <[email protected]> (cherry picked from commit cef4e1e) Signed-off-by: Christoph Paasch <[email protected]>
multipath-tcp · Jul 8, 2020 · eac61ef · eac61ef
1 parent 22010a0
commit eac61ef
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/net/mptcp/mptcp_fullmesh.c b/net/mptcp/mptcp_fullmesh.c
@@ -1773,7 +1773,7 @@ static int mptcp_fm_seq_show(struct seq_file *seq, void *v)
 	mptcp_for_each_bit_set(mptcp_local->loc4_bits, i) {
 		struct mptcp_loc4 *loc4 = &mptcp_local->locaddr4[i];
 
-		seq_printf(seq, "%u, %u, %u, %pI4 %u\n", i, loc4->loc4_id,
+		seq_printf(seq, "%u, %u, %u, %pI4, %u\n", i, loc4->loc4_id,
 			   loc4->low_prio, &loc4->addr, loc4->if_idx);
 	}
 
@@ -1782,7 +1782,7 @@ static int mptcp_fm_seq_show(struct seq_file *seq, void *v)
 	mptcp_for_each_bit_set(mptcp_local->loc6_bits, i) {
 		struct mptcp_loc6 *loc6 = &mptcp_local->locaddr6[i];
 
-		seq_printf(seq, "%u, %u, %u, %pI6 %u\n", i, loc6->loc6_id,
+		seq_printf(seq, "%u, %u, %u, %pI6, %u\n", i, loc6->loc6_id,
 			   loc6->low_prio, &loc6->addr, loc6->if_idx);
 	}
 	rcu_read_unlock_bh();