mptcp: fix Kconfig warning

net/mptcp/Kconfig:62:warning: choice default symbol 'DEFAULT' is not contained in the choice net/mptcp/Kconfig:124:warning: choice default symbol 'DEFAULT' is not contained in the choice Also removed a trailing whitespace introduces in the same commit. Note that it would be nice to prefix all these "DEFAULT_xxx" with "MPTCP_" and even "MPTCP_PM_" / "MPTCP_SCHED_" because it is not obvious to know what they are when you see that in the .config: CONFIG_DEFAULT_DUMMY CONFIG_DEFAULT_FULLMESH CONFIG_DEFAULT_SCHEDULER (...) But I guess it is too late and it should not conflicts with new kconfig because they should always be prefixed with something. Fixes: 54d8697 (Modularize the path-manager) Signed-off-by: Matthieu Baerts <[email protected]> Signed-off-by: Christoph Paasch <[email protected]> (cherry picked from commit 1efcfb3) Signed-off-by: Christoph Paasch <[email protected]>
multipath-tcp · Feb 20, 2020 · b56d4e2 · b56d4e2
1 parent b864616
commit b56d4e2
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/net/mptcp/Kconfig b/net/mptcp/Kconfig
@@ -49,7 +49,7 @@ config MPTCP_NETLINK
 
 choice
 	prompt "Default MPTCP Path-Manager"
-	default DEFAULT
+	default DEFAULT_DUMMY
 	help
 	  Select the Path-Manager of your choice
 
@@ -75,7 +75,7 @@ endif
 config DEFAULT_MPTCP_PM
 	string
 	default "default" if DEFAULT_DUMMY
-	default "fullmesh" if DEFAULT_FULLMESH 
+	default "fullmesh" if DEFAULT_FULLMESH
 	default "ndiffports" if DEFAULT_NDIFFPORTS
 	default "binder" if DEFAULT_BINDER
 	default "default"
@@ -111,7 +111,7 @@ config MPTCP_REDUNDANT
 
 choice
 	prompt "Default MPTCP Scheduler"
-	default DEFAULT
+	default DEFAULT_SCHEDULER
 	help
 	  Select the Scheduler of your choice