-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loss Changes #2
base: main
Are you sure you want to change the base?
Loss Changes #2
Conversation
Added two new loss functions and also made a few small changes
@Philipuss1 hi, may I ask what those two functions do and how they would improve the generation? Ty! |
@illtellyoulater Well, you can experiment with them in the latest version of Majesty Diffusion afaik, but in general, mean loss makes the picture more white and kind of make it look like a sketch, while the var loss is the same as mean loss, but black instead of white. It won't improve your image generation, but if you seek a specific effect on the image, these two loss functions can help |
Thanks! But how do I call those functions? Should I include something in the diffusion schedule? |
@illtellyoulater You can just change the mean_scale and var_scale variables |
Thank you for making this PR! I did a slightly different implementation - so now this loss works directly on latent space., and having a threholding parameter to it.
var_index is the var_scale on different timesteps, var_range defines when the var_loss kick in - only when var > var_range, the var_loss will kick in. |
@Dango233 Ooh this is great! Much better than what I did! |
Added two new loss functions and also made a few small changes