fix: remove the unmaintained proc-macro-error dependency #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can already emit errors directly with `syn`, so we can just drop this dependency entirely.
There was a more recent release which needs a different config. Also make it as strict as it was intended by the original author. And finally use the official GitHub Action to run it on CI.
Closed
|
Note: I've included the other commits from #371 to make CI happy. |
So we can use a newer rust version when checking code coverage, and our compile tests don't fail because of mismatched error messages.
vmx
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Thanks @Stebalien for looking into this more closely and just getting rid of proc-macro-error!
|
Merged by rebase because there are multiple separate changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can already emit errors directly with
syn, so we can just drop this dependency entirely.