Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(codetable): expose all items with required features on docs.rs #361

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

bishopcheckmate
Copy link
Contributor

This change affects only builds on docs.rs. Previously docs.rs built
multihash-codetable with only the default features enabled, thus all
the content of the crate could be inspected only when reading sources.
This change exposes all items from the crate on docs.rs and labels
them with what features they require.

@bishopcheckmate
Copy link
Contributor Author

the result will look like eg. in tokio

@bishopcheckmate
Copy link
Contributor Author

I've bumped the version both here and in #360, however I think only one should come with version bump at the end. Here version bump is required just to rebuild the documentation

@bishopcheckmate
Copy link
Contributor Author

removed the version bump

This change affects only builds on docs.rs. Previously docs.rs built
multihash-codetable with only the default features enabled, thus all
the content of the crate could be inspected only when reading sources.
This change exposes all items from the crate on docs.rs and labels
them with what features they require.
Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements!

@vmx vmx merged commit 0f1329b into multiformats:master Jan 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants