Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting Multibase ready for IETF review (align with IANA terminology and registry governance style) #109
Getting Multibase ready for IETF review (align with IANA terminology and registry governance style) #109
Changes from 23 commits
12705bb
b7307ea
e380b70
5c7594a
b0bf557
d451436
a39f8ac
a1b75a5
9d69e19
e814396
e79d6d8
d875325
c3dbd70
e071bc1
f07376c
f7c29ce
3e8ce2b
dafe60b
b9ca042
52b3c06
be3ab37
caee143
ff1fe45
075fa01
873440d
bb5ae08
ccca39b
d773cd8
4c51364
432b270
e0f3632
d20580d
6eba60f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the README:
This isn't really actionable and I'm unsure what we're supposed to do with these issues. Just a nod and and ignore? I'd like these to be actionable and not leading to cruft in the issue tracker since we already have a tendency toward cruft-buildup.
I think the purpose here might be to get a new implementation/library/system onto a list somewhere, can we just shunt people to open a pull request to add their thing? The "express interest" only really tells me that the issue opener is going to open a new issue telling us what they have in their head, which may be awesome, or may be terrible, but it's not really actionable without a thing or an explicit question--which is fine, but this isn't a template for a question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this be better handled by a GH "Discussion"? TBH I wanted an "expressed interest" tracker somewhere for IETF purposes, because the perennial question of standardization is "for whom is this actually useful outside of the PLN/IPFS community that spawned it?"...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the interest of not holding up this PR, I have just cut that template for now and will open a new PR adding it as a Discussion template.
I only realized just now that discussion templates are also a thing! Separate PR incoming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one's a little better, but I'd still prefer this in PR form rather than this asking us to do the PR for them; I'm not really a user of github issue templates (nor particularly a fan! I did my time in JIRA hell already so I can do without the extreme structure), do we have the tools to shunt people toward a PR with all of these things filled out there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will rework the semantics so that it's more of a placeholder. Maybe something like "open this issue so we can give you timely feedback before you start, but please open a draft PR soon and work there until you can close the issue you just opened" would work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the insertion of this checkbox make it explicit enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I guess -- what I'd like to avoid here is a collection of poorly maintained opened issues with no clear path to getting them closed. If we permission people opening unactionable issues, then we can't take action and have no clear path to closing them.
I think it's fine to have issues opened flagging intent to register, but we have to acknowledge that there's a limit to how long those will be held.