Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr this PR removes the "experimental" protocols like /exp-dns.
David brought up good points against introducing multiaddr protocols with and "experimental" prefix in multiformats/js-multiaddr#39:
I now think we should settle on /dns4 and /dns6 because of the above, and because they carry less complexity than /dns:
resolve()
step will yield: . With /dns, you don't know whether your libp2p stack actually supports the multiaddr, until after you've resolved it.And in addition to this, we still keep /dns free for future uses :)