ls: make ls more consistent with other protocols #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #41 Note: To make the `Ls` helper actually _useful_, it now performs the handshake internally. Really, this library isn't built for interactive use while `ls` _is_ so the interfaces are going to be kind of wonky.
alanshaw
approved these changes
Aug 29, 2019
|
@alanshaw let's wait for a spec change. Want to file a PR? |
alanshaw
pushed a commit
to multiformats/multistream-select
that referenced
this pull request
Sep 4, 2019
In response to multiformats/go-multistream#41 and documenting the change to fix it here multiformats/go-multistream#43.
|
PR here multiformats/multistream-select#19 which I believe matches the implementation here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #41
Note: To make the
Lshelper actually useful, it now performs the handshakeinternally. Really, this library isn't built for interactive use while
lsisso the interfaces are going to be kind of wonky.