perf: outline logic in Decode to allow for stack allocations #174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took extra efforts for this to be a backward compatible change, I think
DecodedMultihash
should return a value struct not a pointer.I also updated the error type to a value because this allows for 1 instead of 2 allocations when erroring.
I originally found this problem by benchmarking
go-cid
:We can see it call
mh.Cast
andmh.Cast
callDecode
and instantly drops theDecodedMultihash
. The point of this is purely to validate the multihash.