Update Australia holidays: remove Adelaide Cup Day holiday pre-1973…

… for South Australia (vacanza#2082)
multidadosti-erp · Nov 18, 2024 · b25070e · b25070e
1 parent 61d6277
commit b25070e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 25 deletions.
diff --git a/holidays/countries/australia.py b/holidays/countries/australia.py
@@ -601,6 +601,7 @@ def _populate_subdiv_sa_public_holidays(self):
                 self._add_holiday_jan_26(name)
 
         # Adelaide Cup Day.
+        # First observed as Public Holidays in 1973: https://racingsa.com.au/blog/2020/03/06/2380/a-little-adelaide-cup-history
         # 2006-2023: changed each year by SA Government Proclamation from the 3rd Monday in May
         # to the 2nd Monday in March.
         # from 2024: changed to the 2nd Monday in March officially.
@@ -609,7 +610,7 @@ def _populate_subdiv_sa_public_holidays(self):
         name = tr("Adelaide Cup Day")
         if self._year >= 2006:
             self._add_holiday_2nd_mon_of_mar(name)
-        else:
+        elif self._year >= 1973:
             self._add_holiday_3rd_mon_of_may(name)
 
         # Easter Saturday.

diff --git a/snapshots/countries/AU_SA.json b/snapshots/countries/AU_SA.json
@@ -5,7 +5,6 @@
     "1950-04-08": "Easter Saturday",
     "1950-04-10": "Easter Monday",
     "1950-04-25": "ANZAC Day",
-    "1950-05-15": "Adelaide Cup Day",
     "1950-06-12": "King's Birthday",
     "1950-10-02": "Labor Day",
     "1950-12-25": "Christmas Day",
@@ -16,7 +15,6 @@
     "1951-03-24": "Easter Saturday",
     "1951-03-26": "Easter Monday",
     "1951-04-25": "ANZAC Day",
-    "1951-05-21": "Adelaide Cup Day",
     "1951-06-11": "King's Birthday",
     "1951-10-01": "Labor Day",
     "1951-12-25": "Christmas Day",
@@ -27,7 +25,6 @@
     "1952-04-12": "Easter Saturday",
     "1952-04-14": "Easter Monday",
     "1952-04-25": "ANZAC Day",
-    "1952-05-19": "Adelaide Cup Day",
     "1952-06-09": "Queen's Birthday",
     "1952-10-06": "Labor Day",
     "1952-12-25": "Christmas Day",
@@ -38,7 +35,6 @@
     "1953-04-04": "Easter Saturday",
     "1953-04-06": "Easter Monday",
     "1953-04-25": "ANZAC Day",
-    "1953-05-18": "Adelaide Cup Day",
     "1953-06-08": "Queen's Birthday",
     "1953-10-05": "Labor Day",
     "1953-12-25": "Christmas Day",
@@ -50,7 +46,6 @@
     "1954-04-19": "Easter Monday",
     "1954-04-25": "ANZAC Day",
     "1954-04-26": "ANZAC Day (observed)",
-    "1954-05-17": "Adelaide Cup Day",
     "1954-06-14": "Queen's Birthday",
     "1954-10-04": "Labor Day",
     "1954-12-25": "Christmas Day",
@@ -61,7 +56,6 @@
     "1955-04-09": "Easter Saturday",
     "1955-04-11": "Easter Monday",
     "1955-04-25": "ANZAC Day",
-    "1955-05-16": "Adelaide Cup Day",
     "1955-06-13": "Queen's Birthday",
     "1955-10-03": "Labor Day",
     "1955-12-25": "Christmas Day",
@@ -72,7 +66,6 @@
     "1956-03-31": "Easter Saturday",
     "1956-04-02": "Easter Monday",
     "1956-04-25": "ANZAC Day",
-    "1956-05-21": "Adelaide Cup Day",
     "1956-06-11": "Queen's Birthday",
     "1956-10-01": "Labor Day",
     "1956-12-25": "Christmas Day",
@@ -83,7 +76,6 @@
     "1957-04-20": "Easter Saturday",
     "1957-04-22": "Easter Monday",
     "1957-04-25": "ANZAC Day",
-    "1957-05-20": "Adelaide Cup Day",
     "1957-06-10": "Queen's Birthday",
     "1957-10-07": "Labor Day",
     "1957-12-25": "Christmas Day",
@@ -94,7 +86,6 @@
     "1958-04-05": "Easter Saturday",
     "1958-04-07": "Easter Monday",
     "1958-04-25": "ANZAC Day",
-    "1958-05-19": "Adelaide Cup Day",
     "1958-06-09": "Queen's Birthday",
     "1958-10-06": "Labor Day",
     "1958-12-25": "Christmas Day",
@@ -105,7 +96,6 @@
     "1959-03-28": "Easter Saturday",
     "1959-03-30": "Easter Monday",
     "1959-04-25": "ANZAC Day",
-    "1959-05-18": "Adelaide Cup Day",
     "1959-06-08": "Queen's Birthday",
     "1959-10-05": "Labor Day",
     "1959-12-25": "Christmas Day",
@@ -116,7 +106,6 @@
     "1960-04-16": "Easter Saturday",
     "1960-04-18": "Easter Monday",
     "1960-04-25": "ANZAC Day",
-    "1960-05-16": "Adelaide Cup Day",
     "1960-06-13": "Queen's Birthday",
     "1960-10-03": "Labor Day",
     "1960-12-25": "Christmas Day",
@@ -127,7 +116,6 @@
     "1961-04-01": "Easter Saturday",
     "1961-04-03": "Easter Monday",
     "1961-04-25": "ANZAC Day",
-    "1961-05-15": "Adelaide Cup Day",
     "1961-06-12": "Queen's Birthday",
     "1961-10-02": "Labor Day",
     "1961-12-25": "Christmas Day",
@@ -138,7 +126,6 @@
     "1962-04-21": "Easter Saturday",
     "1962-04-23": "Easter Monday",
     "1962-04-25": "ANZAC Day",
-    "1962-05-21": "Adelaide Cup Day",
     "1962-06-11": "Queen's Birthday",
     "1962-10-01": "Labor Day",
     "1962-12-25": "Christmas Day",
@@ -149,7 +136,6 @@
     "1963-04-13": "Easter Saturday",
     "1963-04-15": "Easter Monday",
     "1963-04-25": "ANZAC Day",
-    "1963-05-20": "Adelaide Cup Day",
     "1963-06-10": "Queen's Birthday",
     "1963-10-07": "Labor Day",
     "1963-12-25": "Christmas Day",
@@ -160,7 +146,6 @@
     "1964-03-28": "Easter Saturday",
     "1964-03-30": "Easter Monday",
     "1964-04-25": "ANZAC Day",
-    "1964-05-18": "Adelaide Cup Day",
     "1964-06-08": "Queen's Birthday",
     "1964-10-05": "Labor Day",
     "1964-12-25": "Christmas Day",
@@ -172,7 +157,6 @@
     "1965-04-19": "Easter Monday",
     "1965-04-25": "ANZAC Day",
     "1965-04-26": "ANZAC Day (observed)",
-    "1965-05-17": "Adelaide Cup Day",
     "1965-06-14": "Queen's Birthday",
     "1965-10-04": "Labor Day",
     "1965-12-25": "Christmas Day",
@@ -183,7 +167,6 @@
     "1966-04-09": "Easter Saturday",
     "1966-04-11": "Easter Monday",
     "1966-04-25": "ANZAC Day",
-    "1966-05-16": "Adelaide Cup Day",
     "1966-06-13": "Queen's Birthday",
     "1966-10-03": "Labor Day",
     "1966-12-25": "Christmas Day",
@@ -194,7 +177,6 @@
     "1967-03-25": "Easter Saturday",
     "1967-03-27": "Easter Monday",
     "1967-04-25": "ANZAC Day",
-    "1967-05-15": "Adelaide Cup Day",
     "1967-06-12": "Queen's Birthday",
     "1967-10-02": "Labor Day",
     "1967-12-25": "Christmas Day",
@@ -205,7 +187,6 @@
     "1968-04-13": "Easter Saturday",
     "1968-04-15": "Easter Monday",
     "1968-04-25": "ANZAC Day",
-    "1968-05-20": "Adelaide Cup Day",
     "1968-06-10": "Queen's Birthday",
     "1968-10-07": "Labor Day",
     "1968-12-25": "Christmas Day",
@@ -216,7 +197,6 @@
     "1969-04-05": "Easter Saturday",
     "1969-04-07": "Easter Monday",
     "1969-04-25": "ANZAC Day",
-    "1969-05-19": "Adelaide Cup Day",
     "1969-06-09": "Queen's Birthday",
     "1969-10-06": "Labor Day",
     "1969-12-25": "Christmas Day",
@@ -227,7 +207,6 @@
     "1970-03-28": "Easter Saturday",
     "1970-03-30": "Easter Monday",
     "1970-04-25": "ANZAC Day",
-    "1970-05-18": "Adelaide Cup Day",
     "1970-06-08": "Queen's Birthday",
     "1970-10-05": "Labor Day",
     "1970-12-25": "Christmas Day",
@@ -239,7 +218,6 @@
     "1971-04-12": "Easter Monday",
     "1971-04-25": "ANZAC Day",
     "1971-04-26": "ANZAC Day (observed)",
-    "1971-05-17": "Adelaide Cup Day",
     "1971-06-14": "Queen's Birthday",
     "1971-10-04": "Labor Day",
     "1971-12-25": "Christmas Day",
@@ -250,7 +228,6 @@
     "1972-04-01": "Easter Saturday",
     "1972-04-03": "Easter Monday",
     "1972-04-25": "ANZAC Day",
-    "1972-05-15": "Adelaide Cup Day",
     "1972-06-12": "Queen's Birthday",
     "1972-10-02": "Labor Day",
     "1972-12-25": "Christmas Day",

diff --git a/tests/countries/test_australia.py b/tests/countries/test_australia.py
@@ -369,7 +369,8 @@ def test_adelaide_cup_day(self):
             "2024-03-11",
         )
         self.assertHolidayName(name, sa_holidays, dt)
-        self.assertHolidayName(name, sa_holidays, range(1900, 2050))
+        self.assertHolidayName(name, sa_holidays, range(1973, 2050))
+        self.assertNoHolidayName(name, sa_holidays, range(1900, 1973))
         for subdiv in set(Australia.subdivisions) - {"SA"}:
             self.assertNoHolidayName(name, self.subdiv_holidays[subdiv])