Do not block during ephemeral peer exchange #7374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlon
force-pushed
the
block-on-duct-tape
branch
from
3313051 to
94b6507
Compare
dlon
force-pushed
the
block-on-duct-tape
branch
from
94b6507 to
5c8308a
Compare
MarkusPettersson98
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
The firewall blocks the pinger in some circumstances
dlon
force-pushed
the
block-on-duct-tape
branch
from
5c8308a to
3030cfe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is due to #7348. Previously, this could panic since some
Tunnelimplementations useblock_on. This was due to a bug where a blocking function was called during ephemeral peer exchange.Since
spawn_blockingdemands a static lifetime, the fix involves usingblock_in_place.This change is