Migrate from SharedPreferences to DataStore

[kl]

---

This change is 

[linear]

DROID-1688 Migrate from SharedPreferences to DataStore

[Pururun]

Reviewed 13 of 13 files at r1.
Reviewable status: 12 of 13 files reviewed, all discussions resolved

[Rawa]

Reviewed 12 of 13 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kl)

---

android/app/src/main/proto/user_prefs.proto line 8 at r2 (raw file):

message UserPreferences {
  bool is_privacy_disclosure_accepted = 1;
  bool is_latest_changelog_seen = 2;

Should be removed from this PR

[kl]

Reviewable status: 12 of 13 files reviewed, 1 unresolved discussion (waiting on @Rawa)

---

android/app/src/main/proto/user_prefs.proto line 8 at r2 (raw file):

Previously, Rawa (David Göransson) wrote…

Should be removed from this PR

Fixed

[Rawa]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kl)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/repository/UserPreferencesMigration.kt line 15 at r3 (raw file):

    fun migrations(context: Context): List<DataMigration<UserPreferences>> =
        listOf(
            SharedPreferencesMigration(context, sharedPreferencesName = APP_PREFERENCES_NAME) {

@albin-mullvad We don't have anything here historically that we would care about I presume?

[kl]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/repository/UserPreferencesMigration.kt line 15 at r3 (raw file):

Previously, Rawa (David Göransson) wrote…

@albin-mullvad We don't have anything here historically that we would care about I presume?

We do have the Split Tunneling migration but it looks like that is using a different shared preferences file called "split_tunneling". The file that contains the privacy disclosure key is called "${BuildConfig.APPLICATION_ID}.app_preferences"

So the question is, do we only need to care about the privacy disclosure key in "${BuildConfig.APPLICATION_ID}.app_preferences" or could other historical keys be in that file as well?

[Rawa]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kl)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/repository/UserPreferencesMigration.kt line 30 at r4 (raw file):

                    .build()
            }
        )

🌟 Nice

[Rawa]

Reviewable status: complete! all files reviewed, all discussions resolved