Migrate remaining e2e tests to POP

[niklasberglund]

LoginTest and ConnectionTest was migrated since before. This PR migrates remaining end to end tests to use Page Object Pattern.

---

This change is 

[Pururun]

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @niklasberglund)

---

android/test/common/src/main/kotlin/net/mullvad/mullvadvpn/test/common/page/WireGuardCustomPortModal.kt line 6 at r1 (raw file):

import net.mullvad.mullvadvpn.test.common.extension.findObjectWithTimeout

class WireGuardCustomPortModal internal constructor() : Page() {

Modal feels very iOS, but maybe it is something commonly used when using POC? Otherwise I think dialog is fine.

[niklasberglund]

Reviewable status: 8 of 10 files reviewed, 1 unresolved discussion (waiting on @Pururun)

---

android/test/common/src/main/kotlin/net/mullvad/mullvadvpn/test/common/page/WireGuardCustomPortModal.kt line 6 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

Modal feels very iOS, but maybe it is something commonly used when using POC? Otherwise I think dialog is fine.

Right, it is also called CustomPortDialog in the app code so that's a better name. Renamed to WireGuardCustomPortDialog.

[Pururun]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

---

android/test/common/src/main/kotlin/net/mullvad/mullvadvpn/test/common/page/WireGuardCustomPortModal.kt line 6 at r1 (raw file):

Previously, niklasberglund (Niklas Berglund) wrote…

Right, it is also called CustomPortDialog in the app code so that's a better name. Renamed to WireGuardCustomPortDialog.

👍

[Rawa]

Reviewed 8 of 10 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @niklasberglund)

---

android/test/e2e/src/main/kotlin/net/mullvad/mullvadvpn/test/e2e/WebLinkTest.kt line 20 at r2 (raw file):

        on<SettingsPage> { clickFaqAndGuides() }

        on<MullvadWebsite> {}

Same here on<MullvadWebsite>()

---

android/test/e2e/src/main/kotlin/net/mullvad/mullvadvpn/test/e2e/LogoutTest.kt line 24 at r2 (raw file):

        on<AccountPage> { clickLogOut() }

        on<LoginPage> {}

nit: I believe we could just write on<LoginPage>()

[niklasberglund]

Reviewable status: 8 of 10 files reviewed, 1 unresolved discussion (waiting on @Pururun and @Rawa)

---

android/test/e2e/src/main/kotlin/net/mullvad/mullvadvpn/test/e2e/LogoutTest.kt line 24 at r2 (raw file):

Previously, Rawa (David Göransson) wrote…

nit: I believe we could just write on<LoginPage>()

Removed {}

---

android/test/e2e/src/main/kotlin/net/mullvad/mullvadvpn/test/e2e/WebLinkTest.kt line 20 at r2 (raw file):

Previously, Rawa (David Göransson) wrote…

Same here on<MullvadWebsite>()

Removed {}

[Rawa]

Reviewable status: 8 of 10 files reviewed, 1 unresolved discussion (waiting on @Pururun)

---

android/test/e2e/src/main/kotlin/net/mullvad/mullvadvpn/test/e2e/LogoutTest.kt line 24 at r2 (raw file):

Previously, niklasberglund (Niklas Berglund) wrote…

Removed {}

I believe this won't compile, you need the ()

[Pururun]

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)

[niklasberglund]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)

---

android/test/e2e/src/main/kotlin/net/mullvad/mullvadvpn/test/e2e/LogoutTest.kt line 24 at r2 (raw file):

Previously, Rawa (David Göransson) wrote…

I believe this won't compile, you need the ()

You are absolutely right, now the build and tests are passing 👍

[Rawa]

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved