-
Notifications
You must be signed in to change notification settings - Fork 66
Conversation
fixes #111 |
I also updated to package version for negotiator in node-request-error-handler mulesoft-labs/node-request-error-handler#3 will need merged and updated in NPM BEFORE this is merged, as request-error-handler will be bumped to 1.0.3 (travis test should then pass) |
@nmors travis is failing, can you have a look please. |
@sichvoge as I mentioned (when I updated my previous comment), travis will fail until mulesoft-labs/node-request-error-handler#3 is merged first, as the downstream bumped version will not resolve |
I have let the team know about that, and we will resolve the issue as soon as possible. |
We are making use of Caret ranges (https://docs.npmjs.com/misc/semver#caret-ranges-123-025-004)
So by having "request-error-handler": "^1.0.0" in Osprey's package.json and "negotiator": "^0.6.0" in request-error-handler's package.json, we are indeed telling NPM to install the latest minor and patch in 1.x.x for "request-error-handler" and the latest patch in 0.6.x for "negotiator". |
Please merge this and #157 |
@danielwpz: this PR is outdated and doesn't make a difference as @tbruno pointed-out above. Closing. |
No description provided.