W-17463948: Prevent double injection of objects in registry #14066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elrodro83
force-pushed
the
chore/double-inject
branch
2 times, most recently
from
caf9295 to
f75b66e
Compare
|
--validate |
2 similar comments
|
--validate |
|
--validate |
elrodro83
force-pushed
the
chore/double-inject
branch
from
515c0e5 to
302c4b4
Compare
|
--validate |
elrodro83
force-pushed
the
chore/double-inject
branch
from
302c4b4 to
cee2c50
Compare
eze210
requested changes
Dec 17, 2024
| */ | ||
| <T> T inject(T object) throws MuleException; | ||
| <T> T inject(T object) throws IllegalDependencyInjectionException; |
There was a problem hiding this comment.
How can we be sure that other components (from other teams or some customer) don't use this method? Implementing it would be also a problem, but we at least have the NoImplement annotation
| * @throws MuleException if there is an error initializing | ||
| */ | ||
| @SuppressWarnings({"unused"}) | ||
| private void initAfterDeserialisation(MuleContext muleContext) throws MuleException { |
There was a problem hiding this comment.
Do we have a test asserting that we aren't breaking something with this?
There was a problem hiding this comment.
all existing tests that use a persistent object store
| @@ -242,7 +245,7 @@ protected InternalEvent setInternalParamsForNotParamResolver(Component component | |||
| try { | |||
| ((ParametersResolverProcessor<?>) component).resolveParameters(builder, (params, context) -> { | |||
| resolvedParameters.putAll(params.entrySet().stream() | |||
| .collect(toMap(e -> e.getKey(), | |||
| .collect(toMap((Function<? super Entry<String, Supplier<Object>>, ? extends String>) Entry::getKey, | |||
There was a problem hiding this comment.
The older code sounds cleaner in this case
elrodro83
force-pushed
the
chore/double-inject
branch
from
93319e4 to
cdefa22
Compare
elrodro83
changed the title
eze210
approved these changes
Dec 18, 2024
|
--validate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.