Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W-17225272: Fix metadata key id warning #14048

Merged
merged 4 commits into from
Dec 5, 2024
Merged

W-17225272: Fix metadata key id warning #14048

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a7becb8
Fix metadata key id warning
d4nielyan9 Dec 3, 2024
27fbc29
update
d4nielyan9 Dec 3, 2024
be57675
update
d4nielyan9 Dec 3, 2024
a8e4700
update
d4nielyan9 Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions ...ule/runtime/module/extension/internal/loader/utils/JavaMetadataKeyIdModelParserUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,9 @@ private static Optional<MetadataKeyModelParser> getKeyIdResolverModelParser(Outp
&& outputResolverModelParser == null
&& attributesResolverModelParser == null
&& inputResolverModelParsers.isEmpty()) {
LOGGER.warn("A Keys Resolver is being defined without defining an Output Resolver, Input Resolver nor Attributes Resolver");
LOGGER
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to add the TODO that was associated to this log.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry forgot to add this back!

.warn("A Keys Resolver is being defined without defining an Output Resolver, Input Resolver nor Attributes Resolver for element {} of extension {}",
elementName, extensionElement.getName());
}

return keyIdResolverModelParser;
Expand All @@ -247,9 +249,6 @@ private static String getCategoryName(OutputResolverModelParser outputResolverMo
return inputResolverModelParser.getInputResolver().getCategoryName();
}

// TODO W-14195099 - change this once we have `ProblemsReporter` available
LOGGER.warn("A Keys Resolver is being defined without defining an Output Resolver, Input Resolver nor Attributes Resolver");

return null;
}
}