Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure properties message is shown as ERROR when it should be a WARN #563

Closed
afelisatti opened this issue Nov 26, 2021 · 0 comments · Fixed by #571
Closed

Secure properties message is shown as ERROR when it should be a WARN #563

afelisatti opened this issue Nov 26, 2021 · 0 comments · Fixed by #571

Comments

@afelisatti
Copy link

Version used
1.2.0

Describe the bug
When a secure properties config is migrated, since in Mule 4 those properties are distinguished with a secure prefix a report entry is generated explaining that the prefix should be added. However, this is an ERROR level report which makes users believe something went wrong with the migration. Additionally, the message does not seem to be clear enough for people to understand the action they should take.

Expected Behavior
The report entry is clear enough for users to understand they need to change their app and how.

Actual Behavior

               <!--Migration ERROR: Review uses of properties defined in the referenced 
                        file, and add the 'secure' prefix to them. -->
                <!-- For more information refer to: -->
                <!-- * https://docs.mulesoft.com/mule-runtime/4.3/migration-secure-properties-placeholder -->
                <!-- * https://docs.mulesoft.com/mule-runtime/4.3/secure-configuration-properties#usage -->

Reproducible Test Case
This is a report level issue which means it happens when reporting is enabled. If a mock is added to the unit tests, we could assert the message reported.

olamiral-mulesoft referenced this issue in olamiral-mulesoft/mule-migration-assistant Dec 5, 2021
- changed secure property prefix report message level from ERROR to WARN
- added more details to the message
@olamiral-mulesoft olamiral-mulesoft linked a pull request Dec 5, 2021 that will close this issue
TomoDC pushed a commit that referenced this issue Dec 14, 2021
- changed secure property prefix report message level from ERROR to WARN
- added more details to the message
jesica-fera pushed a commit that referenced this issue Mar 14, 2022
- changed secure property prefix report message level from ERROR to WARN
- added more details to the message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant