W-11599413-asyncScope-duke #2365
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dukesphere
commented
Oct 10, 2022
| |=== | ||
|
|
||
| == Async Scopes versus Subflows | ||
|
|
||
| Unlike a subflow, an Async scope: | ||
| Unlike the xref:flow-component.adoc[Subflow}, the Async scope: |
There was a problem hiding this comment.
Suggested change
| Unlike the xref:flow-component.adoc[Subflow}, the Async scope: | |
| // TODO: Provide some context for this section, why we want to distinguish | |
| // the components. | |
| Unlike the xref:flow-component.adoc[Subflow}, the Async scope: |
dukesphere
commented
Oct 11, 2022
|
|
||
| See xref:execution-engine.adoc#backpressure[Back-Pressure Management] for details about Mule behavior after reaching the maximum concurrency value. | ||
| Upon reaching maximum concurrency,the scope cannot receive additional requests. See xref:execution-engine.adoc#backpressure[Back-Pressure Management] for details about the behavior of Mule when it reaches the maximum concurrency value. | ||
| |=== | ||
|
|
||
| == Async Scopes versus Subflows |
There was a problem hiding this comment.
TODO: Remove this section and just talk about async characteristics, not in relation to Subflows
There was a problem hiding this comment.
TODO: @IvanAndresFritzler check if any scope inherits exception strategy from main scope
dukesphere
commented
Oct 11, 2022
|
|
||
| In other words, if the payload of your message is a mutable object (for example, a bean with different fields in it) and a message processor in your Async scope changes the value of one of the fields, the message processors outside of the Async scope see the changed values. | ||
| // TODO: DOES THIS INFO BELONG IN THIS SECTION? |
There was a problem hiding this comment.
TODO: create section title for how async handles mutable objects
dukesphere
commented
Oct 11, 2022
|
|
||
| In other words, if the payload of your message is a mutable object (for example, a bean with different fields in it) and a message processor in your Async scope changes the value of one of the fields, the message processors outside of the Async scope see the changed values. | ||
| // TODO: DOES THIS INFO BELONG IN THIS SECTION? | ||
| // TODO: Do we have a recommendation here? |
There was a problem hiding this comment.
TODO: @IvanAndresFritzler we can say something like copy the payload if going to mutate it, only applies if doing something after the async. would need to add custom code for this.
dukesphere
added
the
DO NOT MERGE (YET)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writer's Quality Checklist
Before merging your PR, did you: