This repository was archived by the owner on Jan 20, 2024. It is now read-only.
Release 4.3.3 #156
Merged
Release 4.3.3 #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes (4.3.3):
Preserve query string params in
authorizationUri(Fixed #144 with #153).Now when
authorizationUricontains contains query string parameters, they are preserved ongetUrimethods calls.Affects methods:
ClientOAuth2.token.getUri,ClientOAuth2.code.getUri.E.g. having
authorizationUri=https://example.com/foo?bar=quxand callinggetUrimethod, the output would be:Before:
https://example.com/foo?bar=qux?client_id=....Now:
https://example.com/foo?bar=qux&client_id=....Do not send empty scopes to an auth server (Fixed #98 with #154).
If
scopesis set to""or[]then we send an empty string to an auth server. Ifscopesis undefined (not set), then we don't send it at all.Affects method:
getUri,ClientOAuth2.owner.getToken,ClientOAuth2.credentials.getToken,ClientOAuth2.jwt.getToken,ClientOAuth2.token.getUri,ClientOAuth2.code.getUri.