Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use vite for Toolpad editor #1999

Merged
merged 28 commits into from
Jul 7, 2023
Merged

Use vite for Toolpad editor #1999

merged 28 commits into from
Jul 7, 2023

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented May 11, 2023 •
edited
Loading

move to vite for the Toolpad editor.

This keeps the old editor around under a TOOLPAD_LEGACY_EDITOR flag for inline comparison. We will remove this in the next release

@Janpot Janpot mentioned this pull request May 14, 2023
Merged
1 task
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 17, 2023
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels May 17, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 18, 2023
@oliviertassinari oliviertassinari added the enhancement This is not a bug, nor a new feature label May 18, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 21, 2023
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels May 23, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 6, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 8, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 8, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 15, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 23, 2023
@Janpot Janpot changed the title WIP use vite for Toolpad editor Use vite for Toolpad editor Jun 29, 2023
@Janpot Janpot mentioned this pull request Jun 29, 2023
Closed
2 tasks
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 6, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 7, 2023
@Janpot Janpot marked this pull request as ready for review July 7, 2023 13:27
@Janpot Janpot merged commit d2aaba9 into mui:master Jul 7, 2023
@Janpot Janpot deleted the vite-editor branch July 7, 2023 15:06
@apedroferreira
Copy link
Member

Just tried it, it seems way faster in development!

@Janpot Janpot mentioned this pull request Jul 9, 2023
Closed
2 tasks
@Janpot Janpot mentioned this pull request Aug 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharatkashyap bharatkashyap bharatkashyap approved these changes

@apedroferreira apedroferreira Awaiting requested review from apedroferreira

Assignees
No one assigned
Labels
enhancement This is not a bug, nor a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Janpot @apedroferreira @bharatkashyap @oliviertassinari