Bump @types/node to ^20.2.3 #9060
Conversation
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
Netlify deploy previewNetlify deploy preview: https://deploy-preview-9060--material-ui-x.netlify.app/ Updated pagesNo updates. These are the results for the performance tests:
|
renovate
bot
force-pushed
the
renovate/node-20.x
branch
from
02fc654 to
6dce028
Compare
| @@ -98,7 +98,7 @@ | |||
| "@types/chai-dom": "^1.11.0", | |||
| "@types/enzyme": "^3.10.12", | |||
| "@types/mocha": "^10.0.1", | |||
| "@types/node": "^20.1.4", | |||
| "@types/node": "^20.2.3", | |||
There was a problem hiding this comment.
Just a thought: shouldn't we keep this version in sync with the version of engines used to avoid any potential issues, where IDE would suggest that a certain API is usable, but it would fail on CI due to a different version of the engine used? 🤔
cc @oliviertassinari @flaviendelangle @cherniavskii @michaldudak @ZeeshanTamboli
There was a problem hiding this comment.
Yeah, we can set it to v14 because this is the version of node we use in our CI:
Line 39 in d6761b8
There was a problem hiding this comment.
Although we will end up with multiple versions on @types/node installed anyway, because other dependencies depend on it - see current lock file:
Lines 3002 to 3010 in d6761b8
I'm not sure which one will be picked up by VSCode.
There was a problem hiding this comment.
Or we could wait and see how mui/material-ui#37173 unfolds and possibly lock it on v18 for the time being. 🤔
There was a problem hiding this comment.
Although we will end up with multiple versions on
@types/nodeinstalled anyway, because other dependencies depend on it
Ahh, yes, that specific v14 coming from the @fast-csv/format a sub-dep of exceljs library 🙈
Honestly, I have no idea why they have @types/node as their dependency... I might be missing something, but it seems like an oversight/bug...
This PR contains the following updates:
^20.1.4->^20.2.3Configuration
📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.