Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[l10n] Improve Arabic (ar-SD) locale for DataGrid (#8094)Co-authored-by: Bilal Shafi <[email protected]> #8094

Merged
merged 2 commits into from
Mar 2, 2023
Merged

[l10n] Improve Arabic (ar-SD) locale for DataGrid (#8094)Co-authored-by: Bilal Shafi <[email protected]> #8094

merged 2 commits into from
Mar 2, 2023

Conversation

atf98
Copy link
Contributor

@atf98 atf98 commented Mar 1, 2023

No description provided.

@atf98 atf98 changed the title Update the missing locales in arSD.ts Update the missing locales in (ar-SD) Mar 1, 2023
@mui-bot
Copy link

mui-bot commented Mar 1, 2023 •
edited
Loading

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 496.8 844.6 727.6 672.7 125.164
Sort 100k rows ms 581.3 1,067 775.8 849.42 162.703
Select 100k rows ms 215.8 233.2 226.9 225.04 6.141
Deselect 100k rows ms 124.7 286.9 175.9 195.78 54.388

Generated by 🚫 dangerJS against 6178847

@MBilalShafi MBilalShafi added component: data grid This is the name of the generic UI component, not the React module! l10n localization needs cherry-pick The PR should be cherry-picked to master after merge labels Mar 2, 2023
@MBilalShafi MBilalShafi changed the title Update the missing locales in (ar-SD) [l10n] Add the missing locales in Arabic (ar-SD) for DataGrid Mar 2, 2023
@MBilalShafi
Copy link
Member

Thanks @atf98 for the contribution, I've run the l10n script to fix the build.

@MBilalShafi MBilalShafi self-requested a review March 2, 2023 08:07
@alexfauquette alexfauquette changed the title [l10n] Add the missing locales in Arabic (ar-SD) for DataGrid [l10n] Improve Arabic (ar-SD) locale for DataGrid Mar 2, 2023
@alexfauquette alexfauquette changed the title [l10n] Improve Arabic (ar-SD) locale for DataGrid [l10n] Improve Arabic (ar-SD) locale for DataGrid (#8094)Co-authored-by: Bilal Shafi <[email protected]> Mar 2, 2023
@alexfauquette alexfauquette merged commit 7d4ff92 into mui:master Mar 2, 2023
@alexfauquette alexfauquette removed the needs cherry-pick The PR should be cherry-picked to master after merge label Mar 2, 2023
@alexfauquette alexfauquette mentioned this pull request Mar 2, 2023
Merged
This was referenced Aug 31, 2024
Closed
Closed
@dexamundsen dexamundsen mentioned this pull request Sep 20, 2024
Closed
@dexamundsen dexamundsen mentioned this pull request Oct 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBilalShafi MBilalShafi Awaiting requested review from MBilalShafi

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! l10n localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atf98 @mui-bot @MBilalShafi @alexfauquette