Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Fix ownerState undefined in theme style overrides #7757

Merged

Conversation

lolaignatova
Copy link
Contributor

Fixes #4413

@mui-bot
Copy link

mui-bot commented Jan 29, 2023

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 470.6 817.6 589.3 628.44 149.222
Sort 100k rows ms 539.5 967 817.9 783.22 157.512
Select 100k rows ms 202.7 279.3 222.5 235.76 29.282
Deselect 100k rows ms 140.7 241.2 190.2 188.36 32.118

Generated by 🚫 dangerJS against 9cbceea

@lolaignatova
Copy link
Contributor Author

lolaignatova commented Jan 31, 2023

Hi MUI team.

Can you please help me to add label to this MR? Because I don't have access unfortunately.
And I see changes on layouts argos step but the reason that comparison is happening with next branch I believe.
It's important to target master branch with this changes. I hope it meets your expectations as well.

@zannager zannager added the component: data grid This is the name of the generic UI component, not the React module! label Jan 31, 2023
@m4theushw m4theushw added the needs cherry-pick The PR should be cherry-picked to master after merge label Feb 10, 2023
Copy link
Member

@m4theushw m4theushw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spending time on this! Your changes seem to impact the commercially licensed code. For any changes of this nature, we require contributors to sign the MUI’s Contributor License Agreement (CLA). However, I can’t find a CLA signed that could cover these changes. Please follow the steps at https://mui-org.notion.site/CLA-Contributor-License-Agreement-92ece655b1584b10b00e4de9e67eedb0 to sign the document.

@m4theushw m4theushw added the CLA: required See https://www.notion.so/mui-org/CLA-Contributor-License-Agreement-92ece655b1584b10b00e4de9e67eedb0 label Feb 10, 2023
@lolaignatova
Copy link
Contributor Author

@m4theushw Done! Thanks for explanation

@zannager zannager added CLA: signed See https://www.notion.so/mui-org/CLA-Contributor-License-Agreement-92ece655b1584b10b00e4de9e67eedb0 and removed CLA: required See https://www.notion.so/mui-org/CLA-Contributor-License-Agreement-92ece655b1584b10b00e4de9e67eedb0 labels Feb 15, 2023
@zannager
Copy link
Member

CLA signed, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA: signed See https://www.notion.so/mui-org/CLA-Contributor-License-Agreement-92ece655b1584b10b00e4de9e67eedb0 component: data grid This is the name of the generic UI component, not the React module! needs cherry-pick The PR should be cherry-picked to master after merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants