Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Improve script commands #183

Merged

Conversation

oliviertassinari
Copy link
Member

Closes #163

@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Aug 16, 2020
@@ -2,18 +2,15 @@
"version": "4.11.0",
"private": true,
"scripts": {
"start": "yarn docs:dev",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation first

"docs:dev": "yarn workspace docs dev",
"docs:build": "yarn workspace docs build",
"docs:export": "yarn workspace docs export",
"docs:typescript:formatted": "yarn workspace docs typescript:transpile",
"storybook:dev": "yarn workspace storybook start",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

symmetry with docs

Comment on lines -13 to -16
"hoist": "lerna bootstrap --hoist",
"bootstrap": "lerna bootstrap",
"build": "lerna run build --stream",
"start": "lerna run start --parallel",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer useful with yarn

@oliviertassinari oliviertassinari merged commit 5d89e7c into mui:master Aug 16, 2020
@oliviertassinari oliviertassinari deleted the improve-global-commands branch August 16, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running "npm run start" fails to compile
1 participant