Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TreeView] Add lazy loading for children of tree items #15308
[TreeView] Add lazy loading for children of tree items #15308
Changes from 7 commits
0918085
45779ba
a29e2d0
765c2a5
7a3fad1
80bcc27
3e1e022
ea5a955
cf18e16
ef26a40
1aff38e
5b9f5f8
addcdb8
c99a9dd
620578e
26ebc5a
0d54f50
aeefe05
081d8a3
c31a456
ce5f0c5
70a2fb8
04466c3
6408dcb
0f5c1bd
88dc0e8
321f004
c552110
fd58f94
d449f19
6cc9de7
996a1b8
a8a603c
90ff8b1
c5802a1
9cbbd44
a9bcc3d
25ce29d
70581b0
8c96d04
476dc72
ec1c2e7
651127a
999a3b7
8f94e35
e91559b
d911bb0
38499c3
dad833b
7cb2532
4f78bc9
d1b573a
11f66ac
e734f78
f9fcea6
016d256
b9df1b3
2973a25
4796b78
1807791
2ea1dd3
d7f8c49
4cf46d5
bb5d8f5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not super clear to me if:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now we are following a DX that is close to the one of the grid.
Once we have an initial version fully working, we will see with the grid and the charts if there are things to share with the grid. Sharing DX is obvious (to me at least), sharing code might be more complex since it's very tight to the internals of each set of components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep I agree, it should be part of the pro plan
I saw the grid discussing moving some lazy loading to the community package, we should just check with them before moving ours to the pro that we aren't doing a mistake, but AFAIK the feature should be rpo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#15373
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So why have data grid data source MIT but tree view data source Pro?
In the case of the data grid data: data source allows to maximize the open source adoption (get to a fully working prototype sooner, the fastest we get there, the least we give people time to try something else, I don't think people say I have 10h, I will try as many grids as possible, but instead, give a 2hrs budget to the first grid, if they feel too slow, kill it, try the next one, and so one) and even if you have the feature, you can't do much with it, you still need the Pro plan for their features. So MIT.
In the case of the Tree View: I would expect developers to be able to implement lazy loading using React Query (TanStack/query#413) with our MIT plan and not to have a too terrible experience. I assumed that our new docs page is about doing more than this, but looking closer, it's not so clear. So maybe the right move is:
Guesses our where a data source could truly shine for cases where: