Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Fix null reference error in GridVirtualScrollbar #15009

Merged
merged 2 commits into from
Nov 5, 2024
Merged

[DataGrid] Fix null reference error in GridVirtualScrollbar #15009

merged 2 commits into from
Nov 5, 2024

Conversation

MBilalShafi
Copy link
Member

@MBilalShafi MBilalShafi commented Oct 17, 2024 •
edited
Loading

Fix #14987

Follow-up:

  • Cherry-pick to v7
  • Test coverage. Low priority as it's a very rarely occurring usecase - Add an issue to track

@MBilalShafi MBilalShafi added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! labels Oct 17, 2024
@mui-bot
Copy link

mui-bot commented Oct 17, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-15009--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against d774860

@MBilalShafi MBilalShafi mentioned this pull request Oct 17, 2024
Closed
@theodoremoreland
Copy link

Hi, @MBilalShafi. Is the only thing preventing a merge the failing argos test?

@MBilalShafi MBilalShafi added the needs cherry-pick The PR should be cherry-picked to master after merge label Nov 5, 2024
@MBilalShafi MBilalShafi marked this pull request as ready for review November 5, 2024 13:35
@MBilalShafi MBilalShafi requested a review from a team November 5, 2024 13:36
@MBilalShafi
Copy link
Member Author

@theodoremoreland I wanted to add some test coverage before merge, added it as a follow-up item and opened the PR for review, it should be soon fixed.

@MBilalShafi MBilalShafi merged commit b834a8c into mui:master Nov 5, 2024
20 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 5, 2024
@MBilalShafi @web-flow
[DataGrid] Fix null reference error in GridVirtualScrollbar (#15009)
65aa556
@github-actions github-actions bot mentioned this pull request Nov 5, 2024
Closed
MBilalShafi added a commit to MBilalShafi/mui-x that referenced this pull request Nov 5, 2024
@MBilalShafi
[DataGrid] Fix null reference error in GridVirtualScrollbar (mui#…
45dc398 
…15009)
@MBilalShafi MBilalShafi mentioned this pull request Nov 5, 2024
Merged
MBilalShafi added a commit that referenced this pull request Nov 5, 2024
@MBilalShafi
[DataGrid] Fix null reference error in GridVirtualScrollbar (#15009…
132f758 
…) (#15289)
@github-actions github-actions bot removed the needs cherry-pick The PR should be cherry-picked to master after merge label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KenanYusuf KenanYusuf KenanYusuf approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! v7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uncaught TypeError: Cannot set properties of null (setting 'scrollTop')
4 participants
@MBilalShafi @mui-bot @theodoremoreland @KenanYusuf