Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code-infra] vitest browser & jsdom modes #14508

Open
wants to merge 291 commits into
base: master
Choose a base branch
from
Open

[code-infra] vitest browser & jsdom modes #14508

wants to merge 291 commits into from

Conversation

JCQuintas
Copy link
Member

@JCQuintas JCQuintas commented Sep 5, 2024 •
edited
Loading

Related mui/material-ui#43625

Minimal changes to have charts tests working in browser mode
Charts are the smallest test suit though

Help toward mui/mui-public#170.

Currently ignoring DateFnsV3 adapter tests in the browser due to vitest-dev/vitest#6483 they work normally in jsdom though.

Running tests

# all
pnpm vitest

# browser
pnpm vitest --project "browser/*"

# jsdom
pnpm vitest --project "jsdom/*"

@JCQuintas JCQuintas added test scope: code-infra Specific to the core-infra product labels Sep 5, 2024
@JCQuintas JCQuintas self-assigned this Sep 5, 2024
@JCQuintas JCQuintas mentioned this pull request Sep 5, 2024
Merged
@mui-bot
Copy link

mui-bot commented Sep 5, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-14508--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 12a33cc

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 10, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Sep 11, 2024
@JCQuintas JCQuintas changed the title [code-infra] vitest browser mode working - charts [code-infra] vitest browser mode Sep 11, 2024
@JCQuintas JCQuintas changed the title [code-infra] vitest browser mode [code-infra] vitest browser & jsdom modes Sep 11, 2024
@JCQuintas JCQuintas mentioned this pull request Sep 11, 2024
Open
@JCQuintas
Copy link
Member Author

@LukasTy @flaviendelangle @noraleonte @arthurbalduini I think I've fixed most of the issues with date-pickers in vitest that I could without going super deep on how everything works 😅

I now need some help with understanding the current errors, and possible ideas on how to fix them.

You can check the current failing tests here:
Vitest Tests (jsdom)
Vitest Tests (browser)

oliviertassinari
oliviertassinari reviewed Sep 11, 2024
View reviewed changes
packages/x-charts/src/ChartsTooltip/contentDisplayed.test.tsx Show resolved Hide resolved
vitest.workspace.ts Outdated
Comment on lines 14 to 22
browser: {
enabled: true,
name: 'chromium',
provider: 'playwright',
headless: true,
// https://playwright.dev
providerOptions: {},
screenshotFailures: false,
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting

.github/workflows/vitest.yml
@@ -0,0 +1,51 @@
name: Vitest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CircleCI please: https://www.notion.so/mui-org/code-infra-Migrate-out-of-CircleCI-42350363b7344380a9961cf9731aae31 for the final version of this effort.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is just for ensuring the changes work while working on them

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the GH workflow given that CircleCI is already setup? 🤔

This was referenced Sep 12, 2024
Closed
Draft
@JCQuintas JCQuintas mentioned this pull request Sep 16, 2024
Closed
6 tasks
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 15, 2025
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Jan 15, 2025
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 20, 2025
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 20, 2025
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Jan 20, 2025
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy left review comments

@oliviertassinari oliviertassinari oliviertassinari left review comments

@Janpot Janpot Janpot left review comments

@flaviendelangle flaviendelangle Awaiting requested review from flaviendelangle

@michaldudak michaldudak Awaiting requested review from michaldudak

@cherniavskii cherniavskii Awaiting requested review from cherniavskii

@alexfauquette alexfauquette Awaiting requested review from alexfauquette

At least 1 approving review is required to merge this pull request.

Assignees

@JCQuintas JCQuintas

Labels
PR: out-of-date The pull request has merge conflicts and can't be merged scope: code-infra Specific to the core-infra product test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JCQuintas @mui-bot @Janpot @oliviertassinari @LukasTy