-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGridPremium] Fix onCellSelectionModelChange
not triggered when additional cell range is selected
#14199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminmeh
added
bug 🐛
Something doesn't work
component: data grid
This is the name of the generic UI component, not the React module!
plan: Premium
Impact at least one Premium user
feature: Cell Selection
Related to the cell selection feature
labels
Aug 14, 2024
Deploy preview: https://deploy-preview-14199--material-ui-x.netlify.app/ |
cherniavskii
approved these changes
Aug 21, 2024
packages/x-data-grid-premium/src/hooks/features/cellSelection/useGridCellSelection.ts
Show resolved
Hide resolved
cherniavskii
changed the title
[DataGridPremium] onCellSelectionModelChange not triggered when additional cell range is selected
[DataGridPremium] Fix Aug 21, 2024
onCellSelectionModelChange
not triggered when additional cell range is selected
arminmeh
force-pushed
the
cell-selection-event-fix
branch
from
August 21, 2024 19:12
13c0a01
to
800d54f
Compare
This was referenced Sep 19, 2024
This was referenced Sep 20, 2024
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
component: data grid
This is the name of the generic UI component, not the React module!
feature: Cell Selection
Related to the cell selection feature
plan: Premium
Impact at least one Premium user
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14184
Another reference is needed to detect the state change and trigger the event